[BD-32] Hooks demo #210
Closed
[BD-32] Hooks demo #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -522,6 +526,16 @@ def post(self, request): | |||
| if response: | |||
| return response | |||
|
|
|||
| try: | |||
| trigger_filter("openedx.lms.auth.pre_register.filter.v1", data) | |||
There was a problem hiding this comment.
it should be data = trigger_filter("openedx.lms.auth.pre_register.filter.v1", data) right?
There was a problem hiding this comment.
We can do something like this.
out = trigger_filter(..)
data = out.get('data')
But in any case, I think that the changes to 'data' in the functions are already being stored in the data dictionary passed as parameter
There was a problem hiding this comment.
Allright, out = trigger_filter(..) makes more sense.
Now, about the data being pass as reference, this could work, but we should not count on this. A filter could replace the dict with a new one and we would by mistake ignore that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR exemplifying how to use Hooks Extension Framework on edx-plaform. Please, be aware that this is just an example, soon we will be publishing the final version.
Supporting information
Please, check out the OEP-50 where there's a deeper explanation of the project and the current version of Hooks Guide on the platform.
Testing instructions
Described in openedx/edx-django-utils#110
Other information
This PR depends on Hooks Extension Freamework: Tooling