chore: update requirements for maple version #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaferMazu
requested review from
dcoa,
danielsgz,
Henrrypg and
JuanDavidBuitrago
|
@Alec4r the PR is failing because Commit lint allow: [build, ci, docs, feat, fix, perf, refactor, revert, style, test] |
danielsgz
previously approved these changes
Sep 2, 2022
dcoa
previously approved these changes
Sep 2, 2022
JuanDavidBuitrago
force-pushed
the
master
branch
from
6d1ad2b
to
592daf3
Compare
JuanDavidBuitrago
dismissed stale reviews from dcoa and danielsgz
via
83aab8a
JuanDavidBuitrago
force-pushed
the
mfmz/update-maple-requirements
branch
3 times, most recently
from
a9daa97
to
2e5940c
Compare
* Added: openedx-events==0.6.0 django<3.3 click<8.0.0 In base.in * Organize and set constraints as in the platform
JuanDavidBuitrago
force-pushed
the
mfmz/update-maple-requirements
branch
from
2e5940c
to
219beb7
Compare
JuanDavidBuitrago
approved these changes
Sep 23, 2022
dcoa
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the dependencies basically by adding in the base.in:
And organized the constraints in base, test and peer dependency.
To avoid problems with updating packages, some constraints were also added.
Note: to run this I did it with the platform version of pip-tools==6.4.0 and pip < 22 (Issue with pip, pip>22 support is given in another release(6.6.0)).
Testing instructions
When installing the plugin on a platform Maple has
openedx-eventsin the version of the platform.Other information
The criterion I used to know whether to add the constraint or not was that when doing the make upgrade the requirement changed more than the patch version. If the package updated minor or major, I restricted it to what directly comes out on the platform (this with the justification that some packages do not version well and breaking changes are made in minor); this way we make sure that the requirements are as in the platform.
This time I had to restrict a lot because maple was out a long time ago and the packages have been updated, but I would expect this not to happen often.
Checklist for Merge