test: add TestPathRedirectionMiddleware integration tests AP-1547
#298
+436
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanttV
force-pushed
the
bav/middleware-integration-tests
branch
2 times, most recently
from
14220fc
to
10dd64f
Compare
BryanttV
force-pushed
the
bav/middleware-integration-tests
branch
9 times, most recently
from
86c3ec7
to
5816b47
Compare
BryanttV
force-pushed
the
bav/middleware-integration-tests
branch
2 times, most recently
from
1564138
to
7724856
Compare
| class TestPathRedirectionMiddleware(BaseIntegrationTest): | ||
| """Integration tests for the PathRedirectionMiddleware.""" | ||
|
|
||
| def setUp(self): |
There was a problem hiding this comment.
Are we considering the process_mktg_redirect test case somewhere?
There was a problem hiding this comment.
Yes, I added new tests: ab56e37
…t to tests/integration/utils.py
BryanttV
force-pushed
the
bav/middleware-integration-tests
branch
from
cf996d8
to
80ed570
Compare
mariajgrimaldi
approved these changes
Nov 13, 2024
| return response.json()["access_token"] | ||
|
|
||
|
|
||
| ACCESS_TOKEN = get_access_token() |
There was a problem hiding this comment.
Out of curiosity, why is this here instead of being in L59? Do other files use it separately?
| Base class for the integration test suite. | ||
| """ | ||
|
|
||
| def __init__(self, *args, **kwargs): |
There was a problem hiding this comment.
Out of curiosity, again. Why are we using __init__ instead of the standard setup for test case classes?
| """ | ||
| domain = f"{prefix}.{settings['LMS_BASE']}" if prefix else settings["LMS_BASE"] | ||
| return { | ||
| "base_url": f"http://{domain}", |
There was a problem hiding this comment.
Is this always going to be http, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds integration tests for the
TestPathRedirectionMiddlewaremiddleware. These tests are executed in the job of Tutor Integration TestsTesting instructions
Check the jobs of Tutor Integration Tests in the PR.
Jira Issue