-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use CourseEnrollmentQuerysetRequested from openedx-filters #159
Conversation
ad4579b
to
084f19c
Compare
Hi @JuanDavidBuitrago , I wanna know if this PR is still important, or maybe we could close it. |
I undertand that this PR need review so I am going to create a card for it to check it in the next sprint |
Hi @Alec4r Its important, but first we need upstream PR is merge: openedx/edx-platform#31331 |
084f19c
to
9074f26
Compare
9074f26
to
36ca980
Compare
@JuanDavidBuitrago I checked the PR openedx/edx-platform#31331 and it's not yet closed. Can we review this PR? Or do we need to wait for the openedx-filter to pass all the tests first? |
I'm going to continue working on it, it has to be merged in this sprint |
Description
This PR make a refactor to use FFI-3 with openedx-filters
Refactor from #156
Testing instructions
Mobile Course Available
true. Go on to configure the key: http://{studio.base}:8001/settings/advanced/{your_course_id}OPEN_EDX_FILTERS_CONFIG
in your site, the request show all courses.More information
You can try the steps in #156 with edx-platform branch