fix: remove deprecated is_buildkit_enabled which now always evaluates…#47
Merged
MaferMazu merged 1 commit intoeduNEXT:mainfrom Mar 4, 2024
Merged
fix: remove deprecated is_buildkit_enabled which now always evaluates…#47MaferMazu merged 1 commit intoeduNEXT:mainfrom
MaferMazu merged 1 commit intoeduNEXT:mainfrom
Conversation
fgosew
added a commit
to fgosew/tutor-contrib-codejail-sagemath
that referenced
this pull request
Jan 18, 2024
fixed an error with "is_buildkit_enabled' is undefined", as this function has been deprecated and can no longer be used since tutor >= 17.0.0. See eduNEXT#47
Contributor
Author
|
checking in on this. any update? |
Contributor
|
Hello, @lpm0073, thanks for this PR. We will review it this week, at the latest, next week. |
Contributor
|
Thanks for your patience @lpm0073. This looks good to me, and I will merge it. Thanks for this contribution ✨ |
fgosew
added a commit
to fgosew/tutor-contrib-codejail-sagemath
that referenced
this pull request
Jun 21, 2024
* Update README.rst * Update Dockerfile Added conda support. Currently sagemath is installed directly. This might change in the future with adding a variable for additional packages like e.g. Pandas among others. * Update README.rst * Update Dockerfile fixed an error with "is_buildkit_enabled' is undefined", as this function has been deprecated and can no longer be used since tutor >= 17.0.0. See eduNEXT#47 * Update Dockerfile * Update Dockerfile - decreased built time Greatly decreased built time through removing the need for chown where possible. Local install now finishes under 1000 seconds built time. * Update setup.py * Update Dockerfile * Update Dockerfile * Create codejailservice_config.py overlay for the configuration of the codejail, mainly to allow for longer execution of code like sagemath, which during import might timeout otherwise. * Rename codejailservice_config.py to config.py * Update Dockerfile * Update Dockerfile * Delete tutorcodejail/templates/codejail/build/codejail/config.py * Update Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per tutor's v17.0.0 change notes,
is_buildkit_enabledis deprecated as the variable now otherwise always evaluates to 'true'.