fix: use tutor config on codejail service and add patches to edit it DS-894#55
Merged
fix: use tutor config on codejail service and add patches to edit it DS-894#55
Conversation
cd33297 to
5693dac
Compare
bra-i-am
approved these changes
May 21, 2024
Contributor
Author
|
@bra-i-am, thanks for your feedback and for noting the inconsistent information in the dev environments. I already fixed it. Can you check to make sure it worked as expected? |
|
@MaferMazu, thanks a lot for the fix, I confirm everything is working! |
MoisesGSalas
requested changes
May 21, 2024
Contributor
Author
|
Thanks for the feedback. Can you review this again @MoisesGSalas? |
MoisesGSalas
approved these changes
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR aims to solve issue #44 by changing the
FLASK_APP_SETTINGSvariable to use the tutor file and adding patches to edit the configuration values.How to test it
tutor dev/local do init --limit codejail.tutor config savetutor dev/local start codejailserviceflask shellapp.config['NAME_OF_YOUR_VARIABLE']Other information
How to create a patch
You can clone this plugin and add a file with the patch name, and inside the file, add the Python configuration. The file needs to be inside the patches folder: https://github.com/eduNEXT/tutor-contrib-codejail/tree/main/tutorcodejail/patches. You should have something like tutorcodejail/patches/codejail-common-settings, and inside:
Or you can add the patch in another plugin following this documentation: https://docs.tutor.edly.io/tutorials/plugin.html#modifying-existing-files-with-patches