Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort breakpoints map by value (asc) before export #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

polarbirke
Copy link
Collaborator

Add a map-sort helper and sort breakpoints before exporting JSON
strings in CSS media queries. This default behaviour can be opted-out
from by setting $im-dangerously-use-unsorted-breakpoints.

Add tests for functions and mixins. Split plugin into different files
that can be imported and tested individually. Add a build step to
publish the concatenated plugin file.

Fixes #13

Add a map-sort helper and sort breakpoints before exporting JSON
strings in CSS media queries. This default behaviour can be opted-out
from by setting $im-dangerously-use-unsorted-breakpoints.

Add tests for functions and mixins. Split plugin into different files
that can be imported and tested individually. Add a build step to
publish the concatenated plugin file.

Fixes eduardoboucas#13
@polarbirke
Copy link
Collaborator Author

Hi @eduardoboucas, do you still maintain this repository? Should I tone down the PR (i.e., remove tests and test-related changes) to make it easier to parse? I'm aware I went a bit overboard.

@eduardoboucas
Copy link
Owner

Ouch, apologies for the super late response! I don't have a lot of bandwidth to maintain this project at the moment. The PR looks great, though. Would you be interested in shepherding the project if I add you as a contributor?

@polarbirke
Copy link
Collaborator Author

polarbirke commented Apr 30, 2021

Ouch, apologies for the super late response! I don't have a lot of bandwidth to maintain this project at the moment.

No problem, I completely understand!

Would you be interested in shepherding the project if I add you as a contributor?

Sure, I'd be honored to help with maintenance. 👍

@eduardoboucas
Copy link
Owner

Great! I sent you an invite.

@polarbirke
Copy link
Collaborator Author

Thank you, accepted!

I'm hoping you still want to have a closer look? I'd feel bad to just merge without even an approval stamp 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map with breakpoint values that are not in ascending order leads to false negatives in JavaScript
2 participants