Skip to content

Commit

Permalink
logging: remove SAN from logs (openservicemesh#2346)
Browse files Browse the repository at this point in the history
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
  • Loading branch information
SanyaKochhar authored Jan 22, 2021
1 parent 98d4675 commit 1e6b29a
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions pkg/envoy/sds/response.go
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,6 @@ func (s *sdsImpl) getRootCert(cert certificate.Certificater, sdscert envoy.SDSCe
return nil, err
}
secret.GetValidationContext().MatchSubjectAltNames = getSubjectAltNamesFromSvcAccount(svcAccounts)
log.Trace().Msgf("Proxy for service=%s, upstream cert=%s will only allow SANs exactly matching: %v",
proxyService, sdscert, subjectAltNamesToStr(secret.GetValidationContext().GetMatchSubjectAltNames()))

case envoy.RootCertTypeForMTLSInbound:
// For inbound certificate validation context, the SAN needs to be the list of all downstream
Expand All @@ -205,8 +203,6 @@ func (s *sdsImpl) getRootCert(cert certificate.Certificater, sdscert envoy.SDSCe
return nil, err
}
secret.GetValidationContext().MatchSubjectAltNames = getSubjectAltNamesFromSvcAccount(svcAccounts)
log.Trace().Msgf("Proxy for service=%s, downstream cert=%s will only allow SANs exactly matching: %v",
proxyService, sdscert, subjectAltNamesToStr(secret.GetValidationContext().GetMatchSubjectAltNames()))

default:
log.Debug().Msgf("SAN matching not needed for cert %s", sdscert)
Expand Down

0 comments on commit 1e6b29a

Please sign in to comment.