envoy/cds: set mandatory connect_timeout on synthetic cluster

`connect_timeout` is mandatory for a cluster. Resolves
the error reported by Envoy when a synthetic cluster
is programmed.

Signed-off-by: Shashank Ram <shashr2204@gmail.com>

pkg/envoy/cds/cluster.go

@@ -79,7 +79,8 @@ func getSyntheticCluster(name string) *xds_cluster.Cluster {
 		ClusterDiscoveryType: &xds_cluster.Cluster_Type{
 			Type: xds_cluster.Cluster_STATIC,
 		},
-		LbPolicy: xds_cluster.Cluster_ROUND_ROBIN,
+		LbPolicy:       xds_cluster.Cluster_ROUND_ROBIN,
+		ConnectTimeout: ptypes.DurationProto(clusterConnectTimeout),
 	}
 }
 

pkg/envoy/cds/cluster_test.go

@@ -148,3 +148,14 @@ func TestGetLocalServiceCluster(t *testing.T) {
 		})
 	}
 }
+
+func TestGetSyntheticCluster(t *testing.T) {
+	assert := tassert.New(t)
+
+	actual := getSyntheticCluster("foo")
+	assert.NotNil(actual)
+	assert.Equal("foo", actual.Name)
+	assert.Equal(&xds_cluster.Cluster_Type{Type: xds_cluster.Cluster_STATIC}, actual.ClusterDiscoveryType)
+	assert.Equal(xds_cluster.Cluster_ROUND_ROBIN, actual.LbPolicy)
+	assert.Equal(ptypes.DurationProto(clusterConnectTimeout), actual.ConnectTimeout)
+}