using connectWorkspaceActions() with stackPane

[mostfa-ayad]

hello
stackPane missing the connectWorkspaceActions() method to using workspace actions over subviews

[edvin]

This could be useful, but StackPane isn't as good a match as TabPane but I think it's doable. We would need to create a property that always contains the top most Node in the children view. When we have that, the rest should be pretty straight forward.

[edvin]

I have added StackPane.connectWorkspaceActions() now, and I'll push a new snapshot to the sonatype repo right away :)

[mostfa-ayad]

thank you

[edvin]

My pleasure. Will you close the issue when you have tested it?

[mostfa-ayad]

i can't test it now . i will do after testing

[mostfa-ayad]

one missing questions
is i can use when refresh in subview and can override onactions in subviews
becuse i have atable in subview and can't do refresh on the table using whenRefresh or by onRefresh

[mostfa-ayad]

this is my final work do you have alook

class UserView : View("Users View") {
    val controller:UserController by inject()
    val model: UserModel by inject()
    override val savable = model.editModeProperty
    override val creatable=!model.editModeProperty
    var list:UserList= UserList()
    init {
        controller.users.setAll(controller.loadUsers())
    }
    override val root=stackpane {
        add(list)
        add<UserEditor>()
        connectWorkspaceActions()
    }
    override fun onCreate() {
        model.item=User()
        model.isNew=true
        model.editMode=true
        model.editor=true
    }
    override fun onSave() {
        model.commit() {

            if (model.isNew) {
                model.item = controller.insertUser(model)
                println(model.item.toJSON())
            } else {
                controller.updateUser(model)
            }
        }
    }

    override fun onDock() {
        with(workspace) {

            button("list"){
                disableWhen(model.editorProperty.not())
                action {
                model.editor=false

                initModel()
            }
            }

                button("edit") {
                    disableWhen(model.editModeProperty)
                    action {
                        model.editMode = true
                        model.editor=true

                    }
                }
            }
        }
    fun initModel(){
        model.editMode=false
        model.isNew=false
    }
    override fun onRefresh() {
        list.userTable.refresh()
    }
}

[edvin]

var list:UserList= UserList() is wrong, it should be injected:

val list: UserList by inject()

:)

[mostfa-ayad]

UserList is not subType of ScopedInstance

[edvin]

Aha, I see :) About refresh - have implemented the functions needed, did you get it to work?

[mostfa-ayad]

if you mean by using var list:UserList= UserList() yes it work

[mostfa-ayad]

if the sub views can inject in the main view it will be perfect

[edvin]

Sure they can :)

[mostfa-ayad]

i'm confuse how :)

[edvin]

Make sure the main view extends View and that they are in the same scope. Then simply declare val mainView: MainView by inject() wherever you need it.

[mostfa-ayad]

ok i changed userList to View from Fragment and inject it in the main view
val listView:UserList by inject()
and call refresh method for refresh table
this is my last comment in this issue
thank you for your help

[edvin]

You're welcome. You can do this with less tight coupling by firing an event in the subview and subscribing to that event in the mainview :)

[mostfa-ayad]

ther is no event in the subview
the sub view is a list of data i need refresh to load data change from restful service
it work now

class UserView : View("Users View") {
    val controller:UserController by inject()
    val model: UserModel by inject()
    val listView:UserList by inject()
    override val savable = model.editModeProperty
    override val creatable=!model.editModeProperty
    init {
        controller.users.setAll(controller.loadUsers())
    }
    override val root=stackpane {
        add<UserList>()
        add<UserEditor>()
        connectWorkspaceActions()
    }
    override fun onCreate() {
        model.item=User()
        model.isNew=true
        model.editMode=true
        model.editor=true
    }
    override fun onSave() {
        model.commit() {

            if (model.isNew) {
                model.item = controller.insertUser(model)
                println(model.item.toJSON())
            } else {
                controller.updateUser(model)
            }
        }
    }

    override fun onDock() {
        with(workspace) {

            button("list"){
                disableWhen(model.editorProperty.not())
                action {
                model.editor=false

                initModel()
            }
            }

                button("edit") {
                    disableWhen(model.editModeProperty)
                    action {
                        model.editMode = true
                        model.editor=true
                    }
                }
            refreshButton.action {
                workspace.onRefresh()
            }
            }
        }
    fun initModel(){
        model.editMode=false
        model.isNew=false
    }

    override fun onRefresh() {
        listView.refresh()
    }
}