Don't start a new thread for each runLater(duration) #836
Conversation
In the current implementation, each call to runLater(duration) creates a new Timer, which in turn creates a new Thread. The threads never seem to get cleaned up, and eventually the process runs out of them.
|
Actually, looking at Timer source, it should eventually clean up after itself, but relies on finalize() to do so. I guess the error I saw was the result of my app doing no/very little memory allocation, while calling runLater every 0.2 seconds.. |
|
I agree if you use this a lot it would be better to create the timer once, though if you need to call something like this regularly you should probably not dispatch new jobs all the time, but rather write your own loop around it. If you could rename the |
|
Well, it's your name, I just moved the var - 4f5008e :) Anyway, any suggestion on what the name should be? |
|
There is a huge difference between a local variable in a function, and a package level variable, even if it's private :) Yeah, that would be fine. |
|
Perfect, thank you! |
|
sorry, I missed the other reference ( |
|
should I open another pull request? |
|
Nah, I'm fixing it and committing now :) |
|
OK, thanks :) |
In the current implementation, each call to runLater(duration) creates a new Timer, which in turn creates a new Thread. The threads never seem to get cleaned up, and eventually the process runs out of them.