(tests) Fix Phan warnings in benchmarks

edwardspec · Jan 4, 2025 · 8a57743 · 8a57743
1 parent bca5cac
commit 8a57743
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 13 deletions.
diff --git a/.phan/config.php b/.phan/config.php
@@ -38,7 +38,7 @@
 	# and we don't want it basing its assumptions on testsuite code when checking the main code.
 	$cfg['directory_list'][] = 'tests/phpunit';
 	$cfg['directory_list'][] = 'tests/common';
-	$cfg['directory_list'][] = 'tests/benchmark';
+	$cfg['directory_list'][] = 'tests/benchmarks';
 
 	# PHPUnit classes, etc. Should be parsed, but not analyzed.
 	$cfg['directory_list'][] = $IP . '/tests';

diff --git a/tests/benchmarks/ModerationBenchmark.php b/tests/benchmarks/ModerationBenchmark.php
@@ -61,7 +61,7 @@ public function getUser() {
 
 	/**
 	 * Returns Title object for testing.
-	 * @param string $suffix Full text of the title, e.g. "Talk:Welsh corgi".
+	 * @param string|int $suffix Full text of the title, e.g. "Talk:Welsh corgi".
 	 * @return Title
 	 *
 	 * During this benchmark, same value is returned for same $suffix,
@@ -83,7 +83,7 @@ abstract public function doActualWork( $iterationNumber );
 
 	/**
 	 * Initialize everything before the tests. Called once.
-	 * @param int $numberOfLoops
+	 * @param int $numberOfLoops @phan-unused-param
 	 */
 	public function beforeBenchmark( $numberOfLoops ) {
 		/* Nothing to do.
@@ -92,7 +92,7 @@ public function beforeBenchmark( $numberOfLoops ) {
 
 	/**
 	 * Same as beforeBenchmark, but is called getDefaultLoops() times.
-	 * @param int $iterationNumber Number of the loop (integer starting with 0).
+	 * @param int $iterationNumber Number of the loop (integer starting with 0). @phan-unused-param
 	 */
 	public function beforeBenchmarkPrepareLoop( $iterationNumber ) {
 		/* Nothing to do.
@@ -206,7 +206,7 @@ public function fastEdit( Title $title, $newText = 'Whatever', $summary = '', Us
 	 * @param string $newText
 	 * @param string $summary
 	 * @param User|null $user
-	 * @return mod_id of the newly inserted row.
+	 * @return int mod_id of the newly inserted row.
 	 */
 	public function fastQueue(
 		Title $title,

diff --git a/tests/benchmarks/approveAll.php b/tests/benchmarks/approveAll.php
@@ -66,12 +66,12 @@ public function beforeBenchmark( $numberOfUsers ) {
 		$editsPerUser = $this->getEditsPerUser();
 
 		for ( $i = 0; $i < $numberOfUsers; $i++ ) {
-			$fakeIP = IPUtils::formatHex( base_convert( $i, 10, 16 ) );
+			$fakeIP = IPUtils::formatHex( base_convert( "$i", 10, 16 ) );
 			$user = User::newFromName( $fakeIP, false );
 
 			$dbw->delete( 'moderation', [ 'mod_user_text' => $fakeIP ], __METHOD__ );
 
-			$modid = false;
+			$modid = 0;
 			for ( $j = 0; $j < $editsPerUser; $j++ ) {
 				$modid = $this->fastQueue(
 					$this->getTestTitle( $i + $j * $numberOfUsers ),

diff --git a/tests/benchmarks/formatTimestamp.php b/tests/benchmarks/formatTimestamp.php
@@ -52,15 +52,15 @@ public function getDefaultLoops() {
 	}
 
 	/**
-	 * @param int $numberOfUsers
+	 * @param int $numberOfUsers @phan-unused-param
 	 */
 	public function beforeBenchmark( $numberOfUsers ) {
 		$this->context = RequestContext::getMain();
 		$this->timestampTools = new TimestampTools();
 	}
 
 	/**
-	 * @param int $i
+	 * @param int $i @phan-unused-param
 	 */
 	public function doActualWork( $i ) {
 		$this->timestampTools->format( '20180101000000', $this->context );

diff --git a/tests/benchmarks/renderSpecial.php b/tests/benchmarks/renderSpecial.php
@@ -46,7 +46,7 @@ public function getNumberOfEntries() {
 	}
 
 	/**
-	 * @param int $numberOfLoops
+	 * @param int $numberOfLoops @phan-unused-param
 	 */
 	public function beforeBenchmark( $numberOfLoops ) {
 		/* Prepopulate 'moderation' table */
@@ -60,7 +60,7 @@ public function beforeBenchmark( $numberOfLoops ) {
 	}
 
 	/**
-	 * @param int $i
+	 * @param int $i @phan-unused-param
 	 */
 	public function doActualWork( $i ) {
 		$this->runSpecialModeration( [

diff --git a/tests/benchmarks/showEdit.php b/tests/benchmarks/showEdit.php
@@ -48,7 +48,7 @@ public function getDefaultLoops() {
 	}
 
 	/**
-	 * @param int $numberOfLoops
+	 * @param int $numberOfLoops @phan-unused-param
 	 */
 	public function beforeBenchmark( $numberOfLoops ) {
 		$this->fastEdit( $this->getTestTitle(), self::TEXT_BEFORE );
@@ -58,7 +58,7 @@ public function beforeBenchmark( $numberOfLoops ) {
 	}
 
 	/**
-	 * @param int $i
+	 * @param int $i @phan-unused-param
 	 */
 	public function doActualWork( $i ) {
 		$html = $this->runSpecialModeration( [