forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
In its first pass, namely gather_loans, the borrow checker tracks the initialization sites among other things it does. It does so for let bindings with initializers but not for bindings in match arms, which are effectively also assignments. This patch does that for borrow checker. Closes rust-lang#12452.
- Loading branch information
Showing
2 changed files
with
64 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
src/test/compile-fail/borrowck-match-binding-is-assignment.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// Test that immutable pattern bindings cannot be reassigned. | ||
|
||
enum E { | ||
Foo(int) | ||
} | ||
|
||
struct S { | ||
bar: int, | ||
} | ||
|
||
pub fn main() { | ||
match 1i { | ||
x => { | ||
x += 1; //~ ERROR re-assignment of immutable variable `x` | ||
} | ||
} | ||
|
||
match Foo(1) { | ||
Foo(x) => { | ||
x += 1; //~ ERROR re-assignment of immutable variable `x` | ||
} | ||
} | ||
|
||
match S { bar: 1 } { | ||
S { bar: x } => { | ||
x += 1; //~ ERROR re-assignment of immutable variable `x` | ||
} | ||
} | ||
|
||
match (1i,) { | ||
(x,) => { | ||
x += 1; //~ ERROR re-assignment of immutable variable `x` | ||
} | ||
} | ||
|
||
match [1,2,3] { | ||
[x,_,_] => { | ||
x += 1; //~ ERROR re-assignment of immutable variable `x` | ||
} | ||
} | ||
} |
ffb315f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ very nice