Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Occlusion in Data Augmentation #3

Closed
thomas-enxuli opened this issue Apr 20, 2021 · 1 comment
Closed

Check Occlusion in Data Augmentation #3

thomas-enxuli opened this issue Apr 20, 2021 · 1 comment

Comments

@thomas-enxuli
Copy link

Thanks for your contribution and your work is very impressive and interesting. Just wondering about the check_occlusion function in the part of instance augmentation ( https://github.com/edwardzhou130/Panoptic-PolarNet/blob/main/dataloader/instance_augmentation.py#L160 ). The goal of this function is to check whether a point is within a (2 metre) range of any point in a point cloud right? Would dist = np.linalg.norm(points-center,axis=0) be dist = np.linalg.norm(points-center,axis=1) instead? When you compute norm on axis 0, it will be a shape of (3, ) for [x, y, z], and on axis 1 will be a shape of (N, ) for number of points.

@edwardzhou130
Copy link
Owner

Yes, you are right. axis should be 1 to get the correct distances. I'll commit a fix for this. Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants