Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shutdown_all for async and sync local kernels #30

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

zTaoplus
Copy link

  • add shutdown_all for async and sync local kernels
  • Align hatch fmt and pre-commit for line length settings.

@edwardzjl
Copy link
Owner

edwardzjl commented Nov 14, 2024

I have a small question, why not using the default line length?

@zTaoplus
Copy link
Author

I have a small question, why not using the default line length?

Due to the default line-length settings in pre-commit's ruff format being different from those in hatch's fmt, and since make lint in CI uses hatch fmt, this inconsistency will lead to CI failure.
To resolve this issue, it is necessary to explicitly specify certain settings (such as line-length) in pyproject.toml to ensure consistent behavior between the two.

@edwardzjl
Copy link
Owner

Thank you for the explanation!

@edwardzjl
Copy link
Owner

Could you please take a look at the pending unittests?

@edwardzjl
Copy link
Owner

Please rebase this PR and let's see if the unittests hang.

@zTaoplus
Copy link
Author

Please rebase this PR and let's see if the unittests hang.

done

@edwardzjl edwardzjl merged commit c830cc5 into edwardzjl:main Nov 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants