feat: Transition LineItemState on fulfillment #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JadeyOlivier
force-pushed
the
jolivier/SONIC-270/Line-Item-Fulfillment-State
branch
3 times, most recently
from
bb9053a to
d014069
Compare
JadeyOlivier
commented
Mar 26, 2024
JadeyOlivier
commented
Mar 26, 2024
JadeyOlivier
force-pushed
the
jolivier/SONIC-270/Line-Item-Fulfillment-State
branch
from
d014069 to
6834fdd
Compare
JadeyOlivier
force-pushed
the
jolivier/SONIC-270/Line-Item-Fulfillment-State
branch
from
6834fdd to
614c499
Compare
grmartin
reviewed
Apr 16, 2024
| @@ -240,6 +258,12 @@ def get_orders_for_customer(self, edx_lms_user_id: int, offset=0, | |||
| def get_customer_by_id(self, customer_id: str) -> CTCustomer: | |||
| return self.base_client.customers.get_by_id(customer_id) # pragma no cover | |||
|
|
|||
| def get_state_by_id(self, state_id: str) -> CTLineItemState: | |||
| return self.base_client.states.get_by_id(state_id) # pragma no cover | |||
There was a problem hiding this comment.
We should test these in the future.
grmartin
reviewed
Apr 16, 2024
|
|
||
| for state_draft in order_states: |
grmartin
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created new LineItemStates in Commercetools with accompanying transitions to track fulfillment process. Coordinator triggers fulfillment on “Fulfillment Pending” events when a Commercetools message is received from the AWS Eventbridge. Based on fulfillment result, the LineItemState is also transitioned to a success or failure state. Initially transitioning the state to 'Fulfillment Pending' is handle in this PR in the Commercetools twou repo
JIRA
SONIC-270