Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add transaction id to returnitem, returnitemid to transaction #265

Merged
merged 9 commits into from
Sep 6, 2024
Merged

feat: Add transaction id to returnitem, returnitemid to transaction #265

merged 9 commits into from
Sep 6, 2024

Conversation

nyujacky
Copy link
Contributor

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post-merge:

@nyujacky nyujacky marked this pull request as draft August 14, 2024 02:50
@nyujacky nyujacky marked this pull request as ready for review August 27, 2024 23:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  commerce_coordinator/apps/commercetools
  clients.py
  utils.py
  commerce_coordinator/apps/commercetools/tests
  test_clients.py
  test_pipeline.py
  test_utils.py
Project Total  

This report was generated by python-coverage-comment-action

@nyujacky nyujacky changed the title WIP: Add transaction id to returnitem, returnitemid to transaction feat: Add transaction id to returnitem, returnitemid to transaction Aug 28, 2024
@nyujacky nyujacky requested review from shafqatfarhan and grmartin and removed request for shafqatfarhan August 28, 2024 14:19
@christopappas christopappas dismissed their stale review September 4, 2024 19:24

coverage added

@nyujacky nyujacky merged commit 436b971 into main Sep 6, 2024
9 checks passed
@nyujacky nyujacky deleted the jng/SONIC-396 branch September 6, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grmartin grmartin grmartin approved these changes

@shafqatfarhan shafqatfarhan Awaiting requested review from shafqatfarhan

@christopappas christopappas Awaiting requested review from christopappas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyujacky @grmartin @christopappas