Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update line items state in single api call #314

Merged
merged 2 commits into from
Jan 2, 2025
Merged

feat: update line items state in single api call #314

merged 2 commits into from
Jan 2, 2025

Conversation

syedsajjadkazmii
Copy link
Contributor

update line items state in single api call in fulfillment task

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post-merge:

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  commerce_coordinator/apps/commercetools
  clients.py 671-675
  commerce_coordinator/apps/commercetools/sub_messages
  tasks.py 112
  commerce_coordinator/apps/commercetools/tests
  constants.py
  test_clients.py
  commerce_coordinator/apps/commercetools/tests/sub_messages
  test_tasks.py
Project Total  

This report was generated by python-coverage-comment-action

@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/SONIC-516 branch 3 times, most recently from dbbc3b7 to 8c0f4c7 Compare December 20, 2024 09:49
aht007
aht007 reviewed Dec 31, 2024
View reviewed changes
Copy link
Member

@aht007 aht007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.

commerce_coordinator/apps/commercetools/clients.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/commercetools/clients.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/commercetools/clients.py Show resolved Hide resolved
commerce_coordinator/apps/commercetools/clients.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/commercetools/sub_messages/tasks.py Show resolved Hide resolved
aht007
aht007 approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@aht007 aht007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syedsajjadkazmii syedsajjadkazmii merged commit 41c5ca3 into main Jan 2, 2025
8 checks passed
@syedsajjadkazmii syedsajjadkazmii deleted the sajjad/SONIC-516 branch January 2, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NawfalAhmed NawfalAhmed NawfalAhmed approved these changes

@aht007 aht007 aht007 approved these changes

@abdullahwaheed abdullahwaheed abdullahwaheed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@syedsajjadkazmii @abdullahwaheed @aht007 @NawfalAhmed