feat: add devstack.py config for credentials #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumarkhan999
force-pushed
the
umar/add-credentials-devstack-config
branch
from
29edfb5
to
71400fb
Compare
mumarkhan999
force-pushed
the
umar/add-credentials-devstack-config
branch
from
71400fb
to
0bf7e0b
Compare
BilalQamar95
approved these changes
Oct 23, 2024
dianakhuang
reviewed
Oct 24, 2024
| @@ -297,6 +297,8 @@ services: | |||
| - edx.devstack.credentials | |||
| ports: | |||
| - "18150:18150" | |||
| volumes: | |||
| - ${PWD}/py_configuration_files/credentials.py:/edx/app/credentials/credentials/credentials/settings/devstack.py | |||
There was a problem hiding this comment.
Not a big deal, especially while we're testing, but I would name the directory 'ida_configuration_files' instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue