feat: Remove Datadog diagnostics plugin app and middleware #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are no longer in use in edxapp as of: - edx/edx-internal#11806 (prod, stage) - edx/edge-internal#790 (edge) Also remove testing dependencies that were only in use by this app. See #692 for merge order.
22 tasks
robrap
reviewed
Oct 22, 2024
Comment on lines
-11
to
-12
| ddtrace # Required for testing datadog_diagnostics app and middleware | ||
| celery # Required for testing datadog_diagnostics app |
There was a problem hiding this comment.
I'm in the middle of copying code and using these references. I guess I can restore all of this, but not really wanting it removed right now. :)
There was a problem hiding this comment.
Oh, we can hold off, then. It's not blocking any other PRs.
robrap
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are no longer in use in edxapp as of:
Also remove testing dependencies that were only in use by this app.
See #692 for merge order.
Merge checklist:
Check off if complete or not applicable: