This repository was archived by the owner on Jan 27, 2023. It is now read-only.
Install edxapp page objects using new directory structure; add Jenkins script#49
Merged
Install edxapp page objects using new directory structure; add Jenkins script#49
Conversation
Contributor
Author
|
whoops, forgot to update the imports. I'll do that now. |
Contributor
Author
|
Updated |
fabfile.py
Outdated
There was a problem hiding this comment.
Not sure what this means. If a copy of the repo does not yet exist under this directory then it will first be cloned there, right?
Checking that the target is a directory might not be enough. In order for the git fetch / checkout to succeed it needs to be a valid git repo. Maybe check that there is a .git subdir?
|
👍 |
Contributor
Author
|
@jzoldak Per our discussion, I updated the script to delete the repo on failure and added a warning about concurrency issues. Could you please take one last look before I merge this? |
…ture Added Jenkins script to configure and run tests for edxapp
|
Let's do it then see if it works. :) |
jzoldak
pushed a commit
that referenced
this pull request
Jan 8, 2014
Install edxapp page objects using new directory structure; add Jenkins script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the fabric commands to install the edxapp pages using the new directory structure: https://github.com/edx/edx-platform/pull/2025
Add a bash script to run the tests in Jenkins.
@jzoldak