fix: add text alternative for external link icon in LTI components#24
Merged
naincy128 merged 1 commit intorelease-ulmofrom Nov 4, 2025
Merged
fix: add text alternative for external link icon in LTI components#24naincy128 merged 1 commit intorelease-ulmofrom
naincy128 merged 1 commit intorelease-ulmofrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the accessibility of LTI (Learning Tools Interoperability) launch elements by adding screen reader support for external link indicators and updating the launch button structure.
- Replaced plain input submit button with a more accessible button element in the LTI fixture
- Added "External link" screen reader text to both the fixture and template to improve accessibility
- Included a status span element in the fixture for potential launch state feedback
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| xmodule/js/fixtures/lti.html | Replaced input submit with button element containing icon, screen reader text, and status span |
| lms/templates/lti.html | Added screen reader text for external link indicator to improve accessibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an accessibility issue in LTI components where the external link icon lacked a text alternative.
Added visually hidden text to ensure screen readers announce that the link opens in a new window, complying with WCAG 1.1.1 (Non-text Content).
Fix Summary
Jira Ticket
COSMO2-719