Skip to content

Conversation

@papphelix
Copy link
Member

Reverts #59

Copilot AI review requested due to automatic review settings December 11, 2025 10:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts a previous revert, thereby re-applying changes that upgrade the hls.js library from version 0.14.17 to 1.6.15. The upgrade includes updating the package dependency and consistently renaming all references from HLS to Hls throughout the video player codebase to align with hls.js v1.x API conventions.

Key Changes:

  • Upgrades hls.js from 0.14.17 to ^1.6.15 in package dependencies
  • Renames all HLS import references to Hls across video player and test files
  • Removes transitive dependencies (url-toolkit, eventemitter3, buffer, base64-js, ieee754) that are no longer required by hls.js v1.x

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Updates hls.js dependency from 0.14.17 to ^1.6.15
package-lock.json Updates hls.js package metadata and removes obsolete transitive dependencies
xmodule/js/src/video/03_video_player.js Renames HLS import to Hls and updates API calls (isSupported)
xmodule/js/src/video/02_html5_hls_video.js Renames HLS import to Hls and updates all API references (constructor, Events, ErrorTypes)
xmodule/js/spec/video/video_player_spec.js Updates test file with Hls import and modifies IIFE signature
Comments suppressed due to low confidence (1)

xmodule/js/spec/video/video_player_spec.js:1101

}(require, define));

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@viv-helix viv-helix merged commit 34bd659 into release-ulmo Dec 11, 2025
70 checks passed
@viv-helix viv-helix deleted the revert-59-revert-57-fix/hls-js-upgrade branch December 11, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants