Replace direct access to tzone attribute #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's best to access object attributes using provided methods, instead of calling attr(x, 'foo'). So xts::indexTZ() should have been used. The tzone attribute is being removed from the xts object after xts version 0.11-2, and will only be attached to the index. indexTZ() is also deprecated and replaced by tzone(), so we shouldn't use indexTZ(). Add a tzone() function that will handle tzone attributes for xts and POSIXct objects. The xts index had a tzone attribute in xts version 0.8-8, so get the index attribute for xts objects, and the tzone attribute for POSIXct (or any other) object. Use xts::tzone() if the loaded xts version is greater than 0.11-2. See joshuaulrich/xts#245 for details. Fixes #37.
|
Great, thank you so much! |
|
Hi Edzer, I need to release the version of xts that triggers this error. This will cause a CRAN check failure in geoSpectral. Can you please prepare a spacetime release in the near future? |
|
Done, now; thanks! |
|
Thank you! I saw {spacetime} in incoming/ when I submitted {xts}, so thanks for getting it to CRAN quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's best to access object attributes using provided methods, instead
of calling attr(x, 'foo'). So xts::indexTZ() should have been used.
The tzone attribute is being removed from the xts object after xts
version 0.11-2, and will only be attached to the index. indexTZ() is
also deprecated and replaced by tzone(), so we shouldn't use indexTZ().
Add a tzone() function that will handle tzone attributes for xts and
POSIXct objects. The xts index had a tzone attribute in xts version
0.8-8, so get the index attribute for xts objects, and the tzone
attribute for POSIXct (or any other) object. Use xts::tzone() if the
loaded xts version is greater than 0.11-2.
See joshuaulrich/xts#245 for details.
Fixes #37.