-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R2] Tab refactoring #406
base: develop
Are you sure you want to change the base?
[R2] Tab refactoring #406
Conversation
-add keyboard accessibility -add role and aria-selected to tab items -add control for right tabs position on vertical -fix inverted for vertical -restracture panes to avoid duplications
To generate the Storybook and Docusaurus websites, write comment with:
To generate only Storybook write comment with:
To generate only Docusaurus write comment with:
|
@eea-jenkins build storybook |
3 similar comments
@eea-jenkins build storybook |
@eea-jenkins build storybook |
@eea-jenkins build storybook |
@eea-jenkins build all |
1 similar comment
@eea-jenkins build all |
❌ Docusaurus build FAILEDCheck https://ci.eionet.europa.eu/job/volto-addons/job/volto-eea-design-system/job/PR-406/5/ for details |
@eea-jenkins build storybook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarantilis I am having problems trying this branch as I get the tab story unresponsive when I switch to the tab accordion story. I expect that it doesn't like something from the withResize hoc and it's called too many times. Tomorrow I can demo this issue which prevents me from properly accepting this work
new PR for the old Tab task
https://taskman.eionet.europa.eu/issues/147811