Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R2] Tab refactoring #406

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

tarantilis
Copy link
Collaborator

-add keyboard accessibility
-add role and aria-selected to tab items
-add control for right tabs position on vertical
-fix inverted for vertical
-restracture panes to avoid duplications
Copy link

github-actions bot commented Nov 1, 2023

👋 @tarantilis

To generate the Storybook and Docusaurus websites, write comment with:

@eea-jenkins build all

To generate only Storybook write comment with:

@eea-jenkins build storybook

To generate only Docusaurus write comment with:

@eea-jenkins build docusaurus

@tarantilis
Copy link
Collaborator Author

@eea-jenkins build storybook

3 similar comments
@tarantilis
Copy link
Collaborator Author

@eea-jenkins build storybook

@g-stamatis
Copy link
Contributor

@eea-jenkins build storybook

@valentinab25
Copy link
Contributor

@eea-jenkins build storybook

@valentinab25
Copy link
Contributor

@eea-jenkins build all

1 similar comment
@valentinab25
Copy link
Contributor

@eea-jenkins build all

@jenkins-ci-eionet-europa-eu
Copy link

@jenkins-ci-eionet-europa-eu
Copy link

❌ Docusaurus build FAILED

Check https://ci.eionet.europa.eu/job/volto-addons/job/volto-eea-design-system/job/PR-406/5/ for details

🔥 @valentinab25

@jenkins-ci-eionet-europa-eu
Copy link

@jenkins-ci-eionet-europa-eu
Copy link

@ichim-david ichim-david marked this pull request as ready for review November 1, 2023 15:33
@tarantilis
Copy link
Collaborator Author

@eea-jenkins build storybook

@jenkins-ci-eionet-europa-eu
Copy link

Copy link
Member

@ichim-david ichim-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarantilis I am having problems trying this branch as I get the tab story unresponsive when I switch to the tab accordion story. I expect that it doesn't like something from the withResize hoc and it's called too many times. Tomorrow I can demo this issue which prevents me from properly accepting this work

@ichim-david ichim-david mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants