Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): Make tabs open when footnote in it #63

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Conversation

dobri1408
Copy link
Contributor

No description provided.

@dobri1408 dobri1408 changed the title (fix): Make tabs open when footnote, and fix the bug in slate table (fix): Make tabs open when footnote in it, and fix the bug in slate table Jan 23, 2024
@dobri1408 dobri1408 changed the title (fix): Make tabs open when footnote in it, and fix the bug in slate table (fix): Make tabs open when footnote in it Mar 6, 2024
@dobri1408 dobri1408 requested a review from ichim-david March 18, 2024 16:39
Copy link
Member

@ichim-david ichim-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dobri1408 I've checked with the default tabs template at it works even when tab is set to vertical.
It does not work when using the accordion template so you need to modify the check so that it works also with it

avoinea
avoinea previously approved these changes Mar 26, 2024
@avoinea avoinea self-requested a review March 26, 2024 14:53
@avoinea avoinea dismissed their stale review March 26, 2024 14:53

see david's comment

@ichim-david ichim-david self-requested a review March 26, 2024 16:36
Copy link
Member

@ichim-david ichim-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed within volto-tabs-block by adding menu-item-text class to the span of the accordion tab like is present in the regular tab

@ichim-david ichim-david merged commit bcd71a4 into develop Mar 26, 2024
6 checks passed
@ichim-david ichim-david deleted the table-and-tabs branch March 26, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants