-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for service providers #21
Conversation
Thanks for the contribution! |
For the failure, I htink you just need
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @gabrielrussoc I have a question for @eed3si9n about the uber jar usage, and whether we should depend on sbt-assembly here or not, but this looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the PR looks good as-is. We'll follow up on how we should publish an über JAR.
@gabrielrussoc thanks again for the contribution! Going to add an uber assembly on the next published version via: #23 |
I believe this has been a known issue since 2009: https://code.google.com/archive/p/jarjar/issues/30
This seems to be the only actively maintained fork of jarjar I could find, so I decided to contribute here.
I added some tests to the ResourceProcessor.
Since we are only using the jarjar cli, I also added the assembly plugin in order to build an uber jar. There were some
module-info.class
clashes so I simply ignored them since we will build it with jdk 8 (and they are most likely useless):