Implement drop-in CLI #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
commented
Oct 3, 2023
| class Main { | ||
| def help(): Unit = Main.printHelp() | ||
|
|
||
| def process(rulesFile: Path, inJar: Path, outJar: Path): Unit = { |
There was a problem hiding this comment.
This is the new entry point, which is used via reflection implemented in MainUtil.runMain.
**Problem** We currently only provide `shadeDirectory` function as the entry point, but it's convenient to have a drop-in replacement entry point at least for `process` command. **Solution** This implements `process` and CLI entry point.
eed3si9n
commented
Oct 3, 2023
| // The zip 'setTime' methods try to convert from the given time to the local time based | ||
| // on java.util.TimeZone.getDefault(). When explicitly specifying the timestamp, we assume | ||
| // this already has been done if desired, so we need to 'convert back' here: | ||
| val localTime = time - java.util.TimeZone.getDefault().getOffset(time) |
There was a problem hiding this comment.
This is the timezone workaround /cc @johnynek
|
This PR introduced a source/binary incompatibility due to the removal of: Shader.bytecodeShader(rules: Seq[ShadeRule], verbose: Boolean)There is now a new method: Shader.bytecodeShader(rules: Seq[ShadeRule], verbose: Boolean, skipManifest: Boolean)What it the correct migration from the old to the new one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We currently only provide
shadeDirectoryfunction as the entry point, but it's convenient to have a drop-in replacement entry point at least forprocesscommand.Solution
This implements
processand CLI entry point.Unzipping code is mostly copied from sbt's IO module.
Note
I am wiping out the timestamp to 2010, in part to deal with cursed JAR files that have 1980-00-00 in the date.
$ unzip -l example/byte-buddy-agent.jar Archive: example/byte-buddy-agent.jar Length Date Time Name --------- ---------- ----- ---- 0 00-00-1980 04:08 META-INF/ 988 00-00-1980 04:08 META-INF/MANIFEST.MF $ unzip -l /var/folders/cx/b301f0rs6d5cq6qnsl3mq2vc0000gn/T/test312139308153536234.jar Archive: /var/folders/cx/b301f0rs6d5cq6qnsl3mq2vc0000gn/T/test312139308153536234.jar Length Date Time Name --------- ---------- ----- ---- 0 01-01-2010 00:00 META-INF/ 0 01-01-2010 00:00 META-INF/maven/