Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change capitalization of secret #17

Closed
wants to merge 2 commits into from
Closed

ci: change capitalization of secret #17

wants to merge 2 commits into from

Conversation

line-o
Copy link
Member

@line-o line-o commented Jul 27, 2023

refs #16

No luck so far. neither capitalisation nor token expiry seem to be the problem.

-- update --

It seems to be a mixture of issues as with a different token and on release (eXist v6.2.0) it is obvious that the environment variable is available inside the docker container.

@line-o
Copy link
Member Author

line-o commented Jul 27, 2023

As discussed with @duncdrum in order to get CI in a functional state we need

  1. a non-expired PAT created from the organization that is available as a secret to the test workflow (node.js.yml)
    that replaces the current one
  2. to test with a different docker image for 5.3.0, if that will build or update the test matrix to run on latest 5.x.x (which is 5.5.1 at the moment)
  3. mark the test on latest exist-db as experimental and allow it to fail

@line-o
Copy link
Member Author

line-o commented Jul 27, 2023

Maybe adapting roaster's workflow would be and advantage

@duncdrum duncdrum mentioned this pull request Jul 27, 2023
@duncdrum
Copy link
Contributor

see #22

@duncdrum duncdrum closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants