Fixes #28 by preventing Buffer being invalidated by GC during a read #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing a read Related to node/joyent#5864
|
|
||
| argv[0] = Undefined(); | ||
| argv[1] = resultBuffer; | ||
| argv[1] = scope.Close(resultBuffer); |
There was a problem hiding this comment.
I don't have access to a windows setup to test this but does scope get defined in this function?
|
Thanks for the PR. I will test this on Linux and OSX to confirm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent the Buffer allocated in EIO_AfterRead from getting invalidated by the GC, which caused a segfault when attempting to use the invalidated handle.
Related to nodejs/node-v0.x-archive#5864