Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false capitalization #530

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Fix false capitalization #530

merged 2 commits into from
Mar 7, 2024

Conversation

klao
Copy link
Contributor

@klao klao commented Mar 7, 2024

With yaml-1.1 the lib incorrectly parses badly capitalized literals like FALse and OfF as a false value. This PR fixes it.

eemeli
eemeli approved these changes Mar 7, 2024
View reviewed changes
Copy link
Owner

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this!

@eemeli eemeli merged commit 1c6fd6a into eemeli:main Mar 7, 2024
16 checks passed
@eliavs-snyk eliavs-snyk mentioned this pull request May 19, 2024
Merged
@2lambda123 2lambda123 mentioned this pull request May 19, 2024
Merged
@beekoticf beekoticf mentioned this pull request May 20, 2024
Merged
@fgarcia fgarcia mentioned this pull request May 20, 2024
Open
@isomeradmin isomeradmin mentioned this pull request May 20, 2024
Merged
@fgarcia fgarcia mentioned this pull request May 24, 2024
Open
@SherfeyInv SherfeyInv mentioned this pull request May 24, 2024
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request May 26, 2024
Open
@caniszczyk caniszczyk mentioned this pull request May 30, 2024
Closed
@schwer schwer mentioned this pull request Jun 4, 2024
Merged
@paaschdigital paaschdigital mentioned this pull request Jun 8, 2024
Open
@richb-hanover richb-hanover mentioned this pull request Jun 9, 2024
Closed
@beekoticf beekoticf mentioned this pull request Jun 23, 2024
Merged
@blambeau blambeau mentioned this pull request Jun 23, 2024
Open
@richb-hanover richb-hanover mentioned this pull request Jun 23, 2024
Closed
@dragos-cojocari dragos-cojocari mentioned this pull request Jun 23, 2024
Open
@Kerzinator24 Kerzinator24 mentioned this pull request Jun 24, 2024
Open
@CedricTheveneau CedricTheveneau mentioned this pull request Jun 24, 2024
Closed
@varmoh varmoh mentioned this pull request Jun 24, 2024
Open
@2lambda123 2lambda123 mentioned this pull request Jun 24, 2024
Merged
@fgarcia fgarcia mentioned this pull request Jun 25, 2024
Open
@caniszczyk caniszczyk mentioned this pull request Jun 27, 2024
Closed
@fgarcia fgarcia mentioned this pull request Jun 29, 2024
Open
@DeFiTON DeFiTON mentioned this pull request Jun 30, 2024
Open
@blixtra blixtra mentioned this pull request Jun 30, 2024
Closed
@dragos-cojocari dragos-cojocari mentioned this pull request Jun 30, 2024
Open
@fgarcia fgarcia mentioned this pull request Jun 30, 2024
Open
@igor-enso igor-enso mentioned this pull request Jul 16, 2024
Merged
@WontonSam WontonSam mentioned this pull request Jul 19, 2024
Open
@LTomer LTomer mentioned this pull request Jul 23, 2024
Open
@DeFiTON DeFiTON mentioned this pull request Aug 15, 2024
Open
@fgarcia fgarcia mentioned this pull request Aug 15, 2024
Open
@dragos-cojocari dragos-cojocari mentioned this pull request Aug 15, 2024
Open
@dragos-cojocari dragos-cojocari mentioned this pull request Sep 7, 2024
Open
@fgarcia fgarcia mentioned this pull request Sep 10, 2024
Closed
@psturc psturc mentioned this pull request Sep 24, 2024
Open
@supriza supriza mentioned this pull request Sep 25, 2024
Merged
@fgarcia fgarcia mentioned this pull request Sep 25, 2024
Merged
@WontonSam WontonSam mentioned this pull request Oct 14, 2024
Open
@Graysonbarton Graysonbarton mentioned this pull request Oct 15, 2024
Open
@tunnckoCore tunnckoCore mentioned this pull request Oct 27, 2024
Open
@suculent suculent mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemeli eemeli eemeli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klao @eemeli