Stop including end comments in collections if next content is not sufficiently indented #54
+43
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
Effectively, when encountering a comment on a new line while parsing a collection, the parser now peeks ahead to see if the next non-comment content is indented at least to the level of this collection, or if there's a subsequent comment that's sufficiently indented. This means that e.g. parsing and re-stringifying this document:
Results in this representation:
Previously, the
#c5
comment would have gained a spurious level of indentation due to being incorrectly attached to thek*
map rather than the root sequence.@ikatyang Did you have some fixes in
yaml-unist-parser
for this following prettier/prettier#4917 that would need to take into account these changes?