Get rid of double-delete bug #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age and as a v8 internal field; Now only as v8 internal field
|
LGTM, but the original project was created by @mikeseven. Do you want to take ownership of this ? A npm module would be awesome! I was looking forward to clean out this code or create a new-from-scratch module. In the meantime, I'll be merging these changes. |
|
I agree we need a proper module for this, and I guess I am in good company when I say I don't have time to take ownership right now :( Thanks for pulling, though :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image::unload used to be unusable, because inevitably the wrapped dib would be double-deleted in Image::~Image, for example as the garbage collector runs.
This patch set fixes this bug by making sure to set the internally stored dib value to NULL as soon as it is deleted in Image::unload.