Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GuiceVerticleLoader needs to be updated for Vert.x 3.8.0. #19

Open
dano opened this issue Jan 10, 2020 · 2 comments
Open

GuiceVerticleLoader needs to be updated for Vert.x 3.8.0. #19

dano opened this issue Jan 10, 2020 · 2 comments

Comments

@dano
Copy link
Contributor

dano commented Jan 10, 2020

In Vert.x 3.8.0, the Verticle method void start(Future<Void> startFuture) is deprecated in favor of void start(Promise<Void> startPromise). However, if you override that in a Verticle that you want to inject via vertx-guice, the start method will not be called, because GuiceVerticleLoader overrides void start(Future<Void> startFuture), and directly calls the same start method on your Verticle.
@dano
Copy link
Contributor Author

dano commented Jan 10, 2020

Ah, I actually just noticed #18 is already open that addresses this.

@Kirik0u
Copy link

Kirik0u commented Mar 2, 2020 •
edited
Loading

Hi,
will there be a version 2.3.2 including this changes ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dano @Kirik0u