Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Promise variants of start and stop methods #18

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jhwarner
Copy link

@jhwarner jhwarner commented Nov 2, 2019

When creating a verticle that overrides the Verticle#start(Promise<Void) method, this module doesn't work correctly and fails to call start.

This is because GuiceVerticleLoader has no implementation of the promise method, which means execution falls to the default method in the Verticle interface. This eventually leads to the GuiceVerticleLoader attempting to call the real verticle's #start(Future<Void> method, rather than the Promise one.

So added the start(Promise<Void>) implementation to GuiceVerticleLoader and created a new test for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants