Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warnings from broccoli .read/.rebuild API #130

Open
gabrielgrant opened this issue May 27, 2018 · 3 comments
Open

Build warnings from broccoli .read/.rebuild API #130

gabrielgrant opened this issue May 27, 2018 · 3 comments

Comments

@gabrielgrant
Copy link

After installing the default latest ember-browserify (v1.2.2) on a fresh app with ember-cli 3.1.4, building yields the following warnings:

[API] Warning: The .read and .rebuild APIs will stop working in the next Broccoli version
[API] Warning: Use broccoli-plugin instead: https://github.com/broccolijs/broccoli-plugin
[API] Warning: Plugin uses .read/.rebuild API: ember-browserify
[API] Warning: Plugin uses .read/.rebuild API: ember-browserify
@ef4
Copy link
Owner

ef4 commented May 29, 2018

Yeah, it looks like there is some housekeeping to do to get up to date.

Does ember-cli-cjs-transform meet your needs? I suspect that most people who would be adding ember-browserify today are better served by that.

@gabrielgrant
Copy link
Author

Ah, interesting, didn't realize browserify was no longer the recommended solution. It looks like ember-cli-cjs-transform should do the trick (though it is still pretty nice how this package allows quickly importing files without any config needed, but having to know how a package was installed in order to use obviously isn't ideal)

@ef4
Copy link
Owner

ef4 commented May 30, 2018

Well I haven't "officially" made any recommendations to not use this yet, but I'm opening the discussion.

I agree that making things Just Work directly from module imports is the goal. The cjs transform is a necessary but not sufficient ingredient. The final step is invoking the cjs transform automatically whenever somebody does import from a module that appears in devDependencies or dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants