Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we deprecate ember-browserify? #131

Closed
ef4 opened this issue May 29, 2018 · 5 comments
Closed

Should we deprecate ember-browserify? #131

ef4 opened this issue May 29, 2018 · 5 comments

Comments

@ef4
Copy link
Owner

ef4 commented May 29, 2018

In favor of ember-cli-cjs-transform? If that had existed first, I would not have created ember-browserify.

Are there use cases I'm missing where browserify does additional things people need?

cc @rwjblue

@rwjblue
Copy link

rwjblue commented May 29, 2018

I am in favor of deprecating...

@stefanpenner
Copy link
Collaborator

:shipit:

@stefanpenner
Copy link
Collaborator

In favor of ember-cli-cjs-transform? If that had existed first, I would not have created ember-browserify.

Ya ^ was inspired by your work on ember-browserify.

@ef4
Copy link
Owner Author

ef4 commented May 30, 2018

On a related note: it seems like maybe only a small amount of hacking to take ember-browserify's parsing step where it discovers imports and modify it so it matches module names against your NPM dependencies and automatically calls app.import with the cjs transform. This would complete the much requested "just import from NPM" feature.

@ef4
Copy link
Owner Author

ef4 commented May 31, 2018

To answer my own question: it was very much not hard.

@ef4 ef4 closed this as completed in 851bcc9 May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants