Make prember accept the latest FastBoot manifest schema 5 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Cannot read property 'htmlFile' of undefined` is what you get when running Prember w/ Embroider, due to Embroider generating a v5 manifest, which Prember is not able to understand. Unfortunately we seem to have to make Prember aware of manifest versions, even though the intention of [fastboot-schema.js](https://github.com/ember-fastboot/fastboot/blob/429eb1d1c3d9353f3085196e71cfde416f154cba/src/fastboot-schema.js) is to abstract this away. But as we mangle the manifest, we can not rely on that. But the change here is not really changing that.
|
Also was not able to add tests here (yet), as even the latest |
simonihmig
added a commit
to simonihmig/prember
that referenced
this pull request
Nov 6, 2020
Update to v3, so `fastboot` is able to understand the v5 manifest schema (related: ef4#61). Otherwise you get `An incompatible version between `ember-cli-fastboot` and `fastboot` was found. Please update the version of fastboot library that is compatible with ember-cli-fastboot.`, so this is another stepping stone to Embroider compatibility.
This was referenced Nov 6, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot read property 'htmlFile' of undefinedis what you get when running Prember w/ Embroider, due to Embroider generating a v5 manifest, which Prember is not able to understand.Unfortunately we seem to have to make Prember aware of manifest versions, even though the intention of fastboot-schema.js is to abstract this away. But as we mangle the manifest, we can not rely on that. But the change here is not really changing that.