Move CI to Github Actions #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, right. @ef4 seems you have to enable GH actions for this repo! (If you agree with the switch here that is) |
Merged
|
Hmm, they're already allowed. I'll just merge it and see if that kicks it off. |
|
Yeah, they ran successfully now on master luckily. It makes sense actually, as kicking off new (unapproved) workflows from a fork (giving them access to secrets) would be a security risk. IIRC I have read about related limitations... |
|
any secrets are not accessible at all which causes a few problems when working with github actions 🙈 but the limitation here is that you need to commit an empty workflow file to master before PRs will start building 👍 thanks for doing this work btw 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for a future Embroider support PR that is expected to add Embroider test scenarios, I wanted to switch to an ember-try based setup. And when doing that, I figured we can move to Github Actions at the same time.
The workflow is based on what my usual setup looks like, but feel free to suggest changes if you want it aligned to other projects or so...