Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply config/fastboot.js the same way that ember-cli-fastboot does #78

Merged
merged 1 commit into from
May 16, 2023

Conversation

mansona
Copy link
Collaborator

@mansona mansona commented May 5, 2023

This lifts the implementation for discovering a config/fastboot.js file directly from ember-cli-fastboot: https://github.com/ember-fastboot/ember-cli-fastboot/blob/master/packages/ember-cli-fastboot/index.js#L386

Essentially since EmberData 4.12 you can't use prember because you need to provide a bunch of globals like AbortController and we aren't currently loading the fastboot.js config file that works with ember-cli-fastboot so it's impossible to run.

This will also fix #77 and #25 because you would just configure the sandbox globals the same way that ember-cli-fastboot tells you to 👍

Fixes #77
Fixes #25
Fixes #76

@mansona
Copy link
Collaborator Author

mansona commented May 5, 2023

I did a bit of work to get CI green again #79 👍 I'll rebase this once that is merged

@mansona mansona force-pushed the fastboot-config branch from 41da09d to b30be93 Compare May 16, 2023 16:42
@mansona mansona merged commit a6feaee into master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildSandboxGlobals doesn't seem to be called when generating pages.
2 participants