Links with return never (#393)

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## [Unreleased][unreleased]
 
 ### Fixed
+- Avoid always terminating calls in links
 - Transformed html attributes
 
 ## [0.13.1] - 2023-06-12

src/Compiler/NodeVisitor/LinkNodeVisitor.php

@@ -14,10 +14,15 @@
 use PhpParser\ConstExprEvaluationException;
 use PhpParser\ConstExprEvaluator;
 use PhpParser\Node;
+use PhpParser\Node\Expr\BinaryOp\Identical;
+use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\PropertyFetch;
 use PhpParser\Node\Expr\StaticCall;
+use PhpParser\Node\Name;
+use PhpParser\Node\Scalar\LNumber;
 use PhpParser\Node\Stmt\Echo_;
+use PhpParser\Node\Stmt\If_;
 use PhpParser\NodeVisitorAbstract;
 use Throwable;
 
@@ -137,7 +142,11 @@ private function prepareNodes(MethodCall $methodCall, array $attributes): ?array
             return null;
         }
 
-        return $expressions;
+        return [
+            new If_(new Identical(new FuncCall(new Name('mt_rand')), new LNumber(0)), [
+                'stmts' => $expressions,
+            ], $attributes),
+        ];
     }
 
     private function isMethodCallUiLink(MethodCall $methodCall): bool

tests/Rule/LatteTemplatesRule/PresenterWithoutModule/Fixtures/LinksPresenter.php

@@ -47,12 +47,18 @@ public function actionArrayParam(array $ids, bool $option = false): void
     {
     }
 
+    /**
+     * @return never
+     */
     public function persistentConflict($persistentConflict)
     {
         $this->redirect('default');
     }
 
-    public function handleDelete(string $id): void
+    /**
+     * @return never
+     */
+    public function handleDelete(string $id)
     {
     }
 }