Update parsing regexes to handle (ignore) milliseconds

- This is a potential fix to the issue brought up in jackc#75
efatsi · Apr 7, 2021 · 2dd60de · 2dd60de
1 parent 3ef83ab
commit 2dd60de
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/lib/tod/time_of_day.rb b/lib/tod/time_of_day.rb
@@ -14,6 +14,7 @@ class TimeOfDay
       ([0-5]\d)?
       :?
       ([0-5]\d)?
+      (?:\.\d{3})?
       \z
     /x
 
@@ -24,6 +25,7 @@ class TimeOfDay
       ([0-5]\d)?
       :?
       ([0-5]\d)?
+      (?:\.\d{3})?
       \s*
       ([ap])
       \.?

diff --git a/test/tod/conversion_test.rb b/test/tod/conversion_test.rb
@@ -88,4 +88,18 @@ class <<t
 
     assert_equal(tod, Tod::TimeOfDay.new(24, 00, 00))
   end
+
+  it "parses 24:00:00.000" do
+    t   = "24:00:00.000"
+    tod = Tod::TimeOfDay(t)
+
+    assert_equal(tod, Tod::TimeOfDay.new(24, 00, 00))
+  end
+
+  it "parses 04:00:00.000 pm" do
+    t   = "04:00:00.000 pm"
+    tod = Tod::TimeOfDay(t)
+
+    assert_equal(tod, Tod::TimeOfDay.new(16, 00, 00))
+  end
 end