Expo app template #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christoph Nakazawa <xnakazawa@pm.me>
create-effect-app - Add inline Expo app configuration after template creation - Prefer local templates/examples when running from a repo checkout - Remove post-create script hook; all post-processing is now inline - Refactor template choices to use Prompt.SelectChoice type - Add NodeTerminal layer for improved prompt support
Allow specifying a template via --template-folder or --template-repo. Update prompts and project creation logic to support these sources. Add parsing and downloading for arbitrary GitHub repo specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to project setup, development workflow, and template management. The most significant changes are the addition of repository guidelines, a new post-create hook for template scaffolding, updates to dependencies and workspace configuration, and enhanced template support for Expo apps. These updates aim to make onboarding, development, and customization smoother and more consistent across the repository.
Documentation and Workflow Improvements:
AGENTS.mdfile outlining repository structure, commands, coding style, testing, commit/PR guidelines, and agent workflow best practices.README.mdwith a clearer quick start guide and project description for Effect Native examples.Template and Scaffolding Enhancements:
packages/create-effect-app/src/Cli.tsthat detects and runs adid-create-effect-appscript after scaffolding a new project or template, improving initial customization and onboarding. [1] [2] [3]did-create-effect-appscript totemplates/basic/scripts/, which lists files with placeholders that typically need user customization after scaffolding.Expo App Template Support:
templates/expo-app(e.g.,.envrc,.gitignore,.prettierignore,.svgrrc,.vscode/extensions.json) to improve developer experience and maintain consistency. [1] [2] [3] [4] [5]scripts/update-expo-app-template.shto streamline updating the Expo app template from upstream while preserving history and filtering out unnecessary files.Dependency and Workspace Updates:
pnpm-lock.yaml, including bumping@effect/language-serviceto0.39.0, and added missing dependencies for core packages. Marked some deprecated packages and cleaned up unused dependencies. [1] [2] [3] [4]nodeLinker: isolatedinpnpm-workspace.yamlfor improved workspace isolation.flake.nixto usemkShellNoCCand addedpnpmto the development shell for better reproducibility.These changes collectively improve the developer onboarding experience, ensure templates are easier to customize, and keep the project dependencies and configuration up to date.