Multiple CI jobs for PRs #1173
Merged
Multiple CI jobs for PRs #1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiribenes
commented
Oct 30, 2025
| ~/.sbt | ||
| ~/.cache/coursier | ||
| key: effekt-build-${{ github.sha }} | ||
| fail-on-cache-miss: true |
Contributor
Author
There was a problem hiding this comment.
Great question: the cache here is a bit misleading, the whole point is to allow multi-machine builds by packaging up the build env after building and then restoring it just before calling sbt testWhatever in order to prevent recompiling
|
|
||
| on: | ||
| pull_request: | ||
|
|
Contributor
There was a problem hiding this comment.
One thing we could consider is adding a concurrency group and cancel running jobs when a new commit is pushed:
concurrency:
group: ci-pr-${{ github.workflow }}-${{ github.head_ref || github.ref }}
cancel-in-progress: true
This saves CI minutes but has the disadvantage that some commits may not be tested and situations can arise where one has to wait longer for any CI feedback (in case of frequent pushes).
timsueberkrueb
approved these changes
Oct 30, 2025
Contributor
timsueberkrueb
left a comment
timsueberkrueb
left a comment
There was a problem hiding this comment.
Thank you, this will improve our developer experience a lot!
danielflat
pushed a commit
that referenced
this pull request
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to speed-up CI by having multiple jobs: total time goes from some 20-30 minutes down to 12!