Nicer error messages on argument list / tuple mismatch #1225
+159
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-studios
reviewed
Nov 28, 2025
| (values.matched, values.extra, values.missing) match { | ||
| case (List((arg: source.ValueArg, _)), Nil, missing@(_ :: _)) => | ||
| (arg.value, name) match { | ||
| case (source.Call(source.IdTarget(source.IdRef(List("effekt"), tupleName, _)), _, tupleArgs, _, _), Some(givenName)) |
Collaborator
There was a problem hiding this comment.
Polymorphism boxing used to use findPrelude to find these more precisely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #668
Continues on from #1205 by having a much more structured representation: instead of just numbers, we actually
alignthe two argument lists, seeing what's in both, what's only expected, and what's only received.Then once we have the information, we can (very hackily!) resolve #668 by providing slightly more specialised messages when argument lists and tuples are mismatched. Note that this message is only shown somewhat conservatively: only if the swap for a tuple could work based on the arg count!
I think that all of these could eventually have quick fixes attached to them :)