-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a relative path for loading the JS main #566
Conversation
Motivation: If you compile some Effekt file like #!/usr/bin/env node
require('/a/long/path/to/./out/main.js').main() Unfortunately, this prevents any attempts at packaging the resulting application in a reasonable way since the path is absolute. |
Currently errors out on Windows with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We also might want to check what happens on the Chez backends wrt this issue 👀 |
effekt/effekt/jvm/src/main/scala/effekt/Runner.scala Lines 217 to 226 in 8c1c057
|
Currently, the generated script for loading the compiled JavaScript uses an absolute path.
This prevents moving the generated files.
This makes it so a relative path is used instead.