Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capability passing for extern definitions #633

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

dvdvgt
Copy link
Collaborator

@dvdvgt dvdvgt commented Oct 2, 2024

Resolves #546

val rewrittenBody = rewrite(body)
b.copy(body = rewrittenBody)
case u: source.ExternBody.Unsupported => u
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd factor this into a separate function rewrite(ExternBody).

Copy link
Contributor

@jiribenes jiribenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jiribenes jiribenes merged commit 8911e76 into master Oct 14, 2024
2 checks passed
@jiribenes jiribenes deleted the feature/extern-cap-passing branch October 14, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler crash on leftover do-call in FFI after capability passing
3 participants