Add resource finalization to handlers #701
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdvgt
commented
Nov 19, 2024
| @@ -445,7 +449,7 @@ object Transformer extends Phase[Typechecked, CoreTransformed] { | |||
| } | |||
|
|
|||
| val body: BlockLit = BlockLit(Nil, List(promptCapt), Nil, List(promptParam), | |||
| Scope(transformedHandlers, transform(prog))) | |||
| Scope(transformedHandlers, transformedProg)) | |||
|
|
|||
| Context.bind(Reset(body)) | |||
There was a problem hiding this comment.
I am not quite sure what the transformation is that is applied here and how to incorporate the new finalizer clauses here.
dvdvgt
commented
Nov 19, 2024
| @@ -659,8 +659,17 @@ class RecursiveDescent(positions: Positions, tokens: Seq[Token], source: Source) | |||
| */ | |||
| def tryExpr(): Term = | |||
| nonterminal: | |||
| `try` ~> stmt() ~ someWhile(handler(), `with`) match { | |||
| case s ~ hs => TryHandle(s, hs) | |||
| `try` ~> stmt() ~ manyWhile(handler(), `with`) ~ finalizerClause(`suspend`, false) ~ finalizerClause(`resume`, true) ~ finalizerClause(`return`, true) ~ finalizerClause(`finally`, true) match { | |||
There was a problem hiding this comment.
For some reason, this breaks the current positions and error messages have the wrong span:
Warning: |[warning] examples/pos/capture/regions.effekt:10:3: Handling effect Dummy, which seems not to be used by the program.
| try { prog() } with Dummy { resume(()) }
| ^
|""".stripMargin
=> Diff (- obtained, + expected)
try { prog() } with Dummy { resume(()) }
- ^
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add resource finalization to handlers. This was already implemented under the branch feature/finalizer, however, the branch is now hilariously outdated and solving the merge conflicts almost impossible. Thus, I manually try to re-implement it.