Fix docker network host addr for macOS #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
matej-g
reviewed
Oct 15, 2021
| @@ -24,7 +25,8 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| dockerLocalSharedDir = "/shared" | |||
| dockerLocalSharedDir = "/shared" | |||
| dockerMacOSGatewayAddr = "gateway.docker.internal" | |||
There was a problem hiding this comment.
Should this be gateway.docker.internal or host.docker.internal? Trying to follow https://docs.docker.com/desktop/mac/networking/#use-cases-and-workarounds and make sense of which is which 🤔.
There was a problem hiding this comment.
I was also a bit confused about this. I went with gateway as NewDockerEnvironment creates a bridge network, in which case host IP wouldn't be viable.
Also, looks like Windows has identical issues as mac: https://docs.docker.com/desktop/windows/networking/
There was a problem hiding this comment.
Thanks for clarifying, I think both might work even on user created bridged network, so in the end it should not make any difference for our use case here.
squat
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the host address for
NewDockerEnvironmentfor macOS. Due to docker networking being different on macOS, getting gateway IP fromdocker network inspectdoesn't work, so a workaround is reaching gateway usinggateway.docker.internal.Based on discussion here.
cc @matej-g