monitoring: use instrumented backoff as default for waiting #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffm-use-default-backoff-for-waiting
branch
from
119b874
to
21ca61c
Compare
yeya24
reviewed
Oct 28, 2023
| } | ||
|
|
||
| // WithWaitBackoff is an option to configure a backoff when waiting on a metric value. | ||
| func WithWaitBackoff(backoffConfig *backoff.Config) MetricsOption { | ||
| return func(o *metricsOptions) { | ||
| o.waitBackoff = backoffConfig | ||
| o.waitBackoff = backoff.New(context.Background(), *backoffConfig) |
There was a problem hiding this comment.
Can we allow passing ctx? Maybe we can add another function WithWaitBackoffCtx to avoid too many changes
There was a problem hiding this comment.
Lets do this in a followup PR!
yeya24
approved these changes
Oct 28, 2023
GiedriusS
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to set the wait backoff once when creating the runnable. It is not concurrency save but i think it was not to begin with. At least
WaitRemovedMetricalso reused the instrumented runnable wait backoff already.